Conversation
Support leading debounce in DebouncedAPI
Fix unnecessary leaderboard entry position bumping
Add API for changing a player with auth's identifier
Add playerId filter to GetEntriesOptions
PR Review: Release 0.52.0🟡 Code Quality
Moving // PlayerAlias.cs — entity now reaches into API layer
Talo.Crypto.WriteFileContent(PlayersAPI.offlineDataPath, content);The 🟡 Potential Bug
After public void HandleIdentifierUpdated(PlayerAuthChangeIdentifierResponse res)
{
Talo.CurrentAlias = res.alias; // updates the reference
Talo.CurrentAlias.WriteOfflineAlias();
SetIdentifierPlayerPref();
// Talo.CurrentPlayer.aliases is never updated
}The fix is to also update the matching alias in 🔵 MinorInconsistent error handling between leading and trailing calls in The leading call silently catches and logs exceptions: ExecuteDebouncedOperation(operation).ContinueWith((t) => {
op.isExecuting = false;
if (t.IsFaulted) Debug.LogError(t.Exception);
}, TaskScheduler.FromCurrentSynchronizationContext());The trailing call propagates the exception to the caller of try { await ExecuteDebouncedOperation(key); }
finally { op.isExecuting = false; op.windowOpen = false; }Both paths should use the same error handling strategy. If unhandled exceptions from trailing calls can surface into Overall the debounce leading/trailing logic and the |
No description provided.