OPTI-1528: handle CC prefix for CEA text tracks on Player API below 11th release#84
Open
adadukin-dolby wants to merge 37 commits intodevelopfrom
Open
Conversation
adadukin-dolby
force-pushed
the
bugfix/OPTI-1528-add-cc-label-if-language-or-label-unknown
branch
from
b124ddd to
03ab98f
Compare
adadukin-dolby
force-pushed
the
bugfix/OPTI-1528-add-cc-label-if-language-or-label-unknown
branch
from
57f42c8 to
e826a42
Compare
adadukin-dolby
force-pushed
the
bugfix/OPTI-1528-add-cc-label-if-language-or-label-unknown
branch
from
e826a42 to
cd1c24a
Compare
MattiasBuelens
requested changes
Mar 16, 2026
adadukin-dolby
commented
Mar 16, 2026
adadukin-dolby
commented
Mar 17, 2026
Contributor
Author
|
@MattiasBuelens I think we may want to wait until the changes are live to be able to run tests alongside the PR |
MattiasBuelens
force-pushed
the
bugfix/OPTI-1528-add-cc-label-if-language-or-label-unknown
branch
2 times, most recently
from
a3fe16e to
597050f
Compare
MattiasBuelens
force-pushed
the
bugfix/OPTI-1528-add-cc-label-if-language-or-label-unknown
branch
from
a89ddbe to
475dd6e
Compare
MattiasBuelens
approved these changes
Mar 27, 2026
| @@ -64,18 +67,33 @@ fun formatTime(time: Double, guide: Double = 0.0, preferNegative: Boolean = fals | |||
| */ | |||
| @Composable | |||
| fun formatTrackLabel(track: Track): String { | |||
Collaborator
There was a problem hiding this comment.
This is technically speaking public API, so I've renamed it back to formatTrackLabel with the same signature. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.