fix: improve exception handling in tencent tts speech synthesizer#2090
Open
Jah-yee wants to merge 2 commits intoTEN-framework:mainfrom
Open
fix: improve exception handling in tencent tts speech synthesizer#2090Jah-yee wants to merge 2 commits intoTEN-framework:mainfrom
Jah-yee wants to merge 2 commits intoTEN-framework:mainfrom
Conversation
added 2 commits
March 6, 2026 08:07
…ension Replace all print() statements in _send_dingtalk_message method with ten_env.log_info() and ten_env.log_error() for proper logging. This ensures logs are handled consistently with the rest of the TEN framework extension logging pattern instead of going to stdout.
- Replace bare except with specific exceptions (json.JSONDecodeError, ValueError) - Use explicit chunk_size=None instead of None for clarity in iter_content These changes improve code quality by: 1. Catching only expected exceptions instead of all exceptions 2. Making the code more readable with explicit parameter name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Summary
This PR improves exception handling in the Tencent TTS speech synthesizer by:
Replacing bare except with specific exceptions: Changed
except:toexcept (json.JSONDecodeError, ValueError):to catch only the expected JSON parsing errors rather than all possible exceptions.Using explicit parameter name: Changed
r.iter_content(None)tor.iter_content(chunk_size=None)for better code clarity and readability.Changes
ai_agents/agents/ten_packages/extension/tencent_tts_python/src/speech_synthesizer.pyexcept:withexcept (json.JSONDecodeError, ValueError):chunk_size=Noneiniter_content()Testing
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。
Warmly,