task/WI-433: Route user to system homeDir after successful credential creation#1273
Open
rstijerina wants to merge 3 commits intomainfrom
Open
task/WI-433: Route user to system homeDir after successful credential creation#1273rstijerina wants to merge 3 commits intomainfrom
homeDir after successful credential creation#1273rstijerina wants to merge 3 commits intomainfrom
Conversation
…after successful push keys
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
- Coverage 63.86% 63.77% -0.10%
==========================================
Files 451 451
Lines 13481 13508 +27
Branches 2658 2663 +5
==========================================
+ Hits 8610 8615 +5
- Misses 4532 4552 +20
- Partials 339 341 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sophia-massie
approved these changes
Apr 10, 2026
Contributor
sophia-massie
left a comment
There was a problem hiding this comment.
LGTM. Didn't test pushing keys, but it is directing me to the right directory on Expanse locally and on pprd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
After a user successfully creates credentials via the SystemsPushKeysModal in the datafiles view, we evaluate the correct
homeDirfor the user and redirect the user to this new path, correctly loading their data.Related
Changes
Testing
Also in pprd: https://pprd.core-oidc.tacc.cloud/
client.systems.removeUserCredential(systemId='vista', userName='sal')(ping me if want me to run this)