Skip to content

task/WI-433: Route user to system homeDir after successful credential creation#1273

Open
rstijerina wants to merge 3 commits intomainfrom
task/WI-433--reroute-to-home-after-creds
Open

task/WI-433: Route user to system homeDir after successful credential creation#1273
rstijerina wants to merge 3 commits intomainfrom
task/WI-433--reroute-to-home-after-creds

Conversation

@rstijerina
Copy link
Copy Markdown
Member

@rstijerina rstijerina commented Apr 8, 2026

Overview

After a user successfully creates credentials via the SystemsPushKeysModal in the datafiles view, we evaluate the correct homeDir for the user and redirect the user to this new path, correctly loading their data.

Related

Changes

  • systems push keys endpoint now returns an evaluated "system" for the client side to use

Testing

Also in pprd: https://pprd.core-oidc.tacc.cloud/

  1. Delete your credentials with tapipy, e.g. client.systems.removeUserCredential(systemId='vista', userName='sal') (ping me if want me to run this)
  2. Go to https://cep.test/workbench/data/tapis/private/vista
  3. Enter your credentials and submit
  4. Confirm you are redirected to your $HOME dir after success

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 18.42105% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.77%. Comparing base (74f4b1c) to head (299210d).

Files with missing lines Patch % Lines
server/portal/apps/accounts/api/views/systems.py 15.78% 16 Missing ⚠️
client/src/redux/reducers/datafiles.reducers.js 11.11% 7 Missing and 1 partial ⚠️
...onents/DataFiles/DataFilesTable/DataFilesTable.jsx 42.85% 3 Missing and 1 partial ⚠️
client/src/redux/sagas/systems.sagas.js 0.00% 2 Missing ⚠️
...mmon/SystemsPushKeysModal/SystemsPushKeysModal.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
- Coverage   63.86%   63.77%   -0.10%     
==========================================
  Files         451      451              
  Lines       13481    13508      +27     
  Branches     2658     2663       +5     
==========================================
+ Hits         8610     8615       +5     
- Misses       4532     4552      +20     
- Partials      339      341       +2     
Flag Coverage Δ
javascript 66.77% <21.05%> (-0.11%) ⬇️
unittests 60.61% <15.78%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mmon/SystemsPushKeysModal/SystemsPushKeysModal.jsx 54.54% <0.00%> (-1.71%) ⬇️
client/src/redux/sagas/systems.sagas.js 0.00% <0.00%> (ø)
...onents/DataFiles/DataFilesTable/DataFilesTable.jsx 85.03% <42.85%> (-2.11%) ⬇️
client/src/redux/reducers/datafiles.reducers.js 12.64% <11.11%> (-0.18%) ⬇️
server/portal/apps/accounts/api/views/systems.py 36.36% <15.78%> (-7.76%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't test pushing keys, but it is directing me to the right directory on Expanse locally and on pprd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants