Skip to content

feat: target for ext link respects more subdomains #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wesleyboar wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: target for ext link respects more subdomains #943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0527954
feat: target for ext link respects more subdomains
wesleyboar May 1, 2025
fa61874
feat: reverse subdomain check
wesleyboar May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions taccsite_cms/static/site_cms/js/modules/setTargetForExternalLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,29 @@
*/
export const DEFAULT_LINKS = document.querySelectorAll('body > :is(header, main, footer) a');

/**
* Check if two hosts are effectively the same domain
* @param {string} linkHost - The host from the link
* @param {string} baseHost - The current page's host
* @param {string[]} subdomains - List of valid subdomains
* @returns {boolean}
*/
function isSameDomain(linkHost, baseHost, subdomains) {
// Direct match
if (linkHost === baseHost) return true;

// Link is to subdomain of base host
if (subdomains.some(subdomain => linkHost === `${subdomain}.${baseHost}`)) return true;

// Link is to root domain while we're on subdomain
if (subdomains.some(subdomain =>
baseHost.startsWith(`${subdomain}.`) &&
linkHost === baseHost.replace(`${subdomain}.`, '')
)) return true;

return false;
}

/**
* Make links with absolute URLs open in new tab, and:
* - add accessible markup
Expand All @@ -18,7 +41,10 @@ export default function findLinksAndSetTargets( links = DEFAULT_LINKS, opts = {
shouldFilter: true,
}) {
const baseDocHost = document.location.host;
const baseDocHostWithSubdomain= `www.${ baseDocHost }`;
const standardSubdomains = ['www', 'pprd', 'prod', 'dev'];
const similarHosts = standardSubdomains.map(
subdomain => `${subdomain}.${baseDocHost}`
);

if ( opts.shouldDebug ) {
console.log({ links, opts });
Expand All @@ -33,7 +59,7 @@ export default function findLinksAndSetTargets( links = DEFAULT_LINKS, opts = {

const isMailto = ( linkHref.indexOf('mailto:') === 0 );
const isAbsolute = ( linkHref.indexOf('http') === 0 );
const isSameHost = ( link.host === baseDocHost || link.host === baseDocHostWithSubdomain );
const isSameHost = isSameDomain(link.host, baseDocHost, standardSubdomains);
const shouldOpenInNewTab = ( ! isSameHost || isMailto );

if (opts.shouldDebug) {
Expand Down