feat(djangocms_blog): drop scripts in favor of template overwrites#596
Merged
wesleyboar merged 7 commits intomainfrom Feb 7, 2023
Merged
feat(djangocms_blog): drop scripts in favor of template overwrites#596wesleyboar merged 7 commits intomainfrom
wesleyboar merged 7 commits intomainfrom
Conversation
wesleyboar
force-pushed
the
task/blog-post-item-template
branch
5 times, most recently
from
cdaca97 to
db5e7d4
Compare
Drop JS dom manipulation in favor of new markup directly in template.
wesleyboar
force-pushed
the
task/blog-post-item-template
branch
from
db5e7d4 to
f0092b0
Compare
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Feb 7, 2023
- change CMS image to one with zero javascript for class names:
TACC/Core-CMS#596
- reduced open-external-post.html script complexity
jarosenb
pushed a commit
to TACC/tup-ui
that referenced
this pull request
Feb 7, 2023
* feat(core-cms): TACC_BLOG_SHOW_ABSTRACT_TAG * feat(tup-cms): TACC_BLOG_SHOW_ABSTRACT_TAG * feat(tup-cms): TACC/Core-CMS #594 and #581 * feat(tup-cms): blog article url snippets * chore(tup-cms): rename recent snippet * fix(tup-cms): blog list external url new window * fix(tup-cms): blog list external url script bugs * feat(tup-cms): TACC/Core-CMS#587 w/ #594 from main * fix(tup-cms): move new snippet script to news/ * fix(tup-cms): redirect snippet bugs * feat(tup-cms): limit article url trick to a tag * chore(tup-cms): change abstract tag setting * fix(tup-cms): no redirect if user is editing * docs(tup-cms): better comments external link js * fix(tup-cms): less javascript to open article - change CMS image to one with zero javascript for class names: TACC/Core-CMS#596 - reduced open-external-post.html script complexity * feat(tup-cms): new js module gets article ext. url * feat(tup-cms): redirect js auto-finds article url * fix(tup-cms): redirect js shall not override user If user says redirect to X, snippet shall not ignore on articles. * chore(tup-cms): nx format:write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Clone and edit more templates from https://github.com/nephila/djangocms-blog/blob/1.1.1/djangocms_blog/templates/djangocms_blog/, and remove JavaScript DOM manipulation.
Details
Rather than be so afraid of updates to templates, such that I would rather use JavaScript to change the markup, assume templates rarely change, and that their API—i.e. the context variables—do not change.
Related
Changes
See commits (which are change-specific and polished).
Testing & UI
I tested the changes. I skipped the recording. I am sorry.
Update: Had I recorded testing and UI, I would have caught #597 before merge.