Skip to content

Update CNS validation logic#60

Merged
geidsonc merged 2 commits intomasterfrom
update-cns-validation-starting-with-5-342378906075137649
Mar 2, 2026
Merged

Update CNS validation logic#60
geidsonc merged 2 commits intomasterfrom
update-cns-validation-starting-with-5-342378906075137649

Conversation

@geidsonc
Copy link
Member

@geidsonc geidsonc commented Mar 2, 2026

Updated the isValidCns() function in src/Helpers/Validate.php to include CNS numbers starting with 5 in the temporary validation logic. Also updated tests/Helpers/ValidateTest.php with valid and invalid examples for CNS starting with 5 as requested.

Fixes #59


PR created automatically by Jules for task 342378906075137649 started by @geidsonc

Co-authored-by: geidsonc <9142676+geidsonc@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@geidsonc geidsonc self-assigned this Mar 2, 2026
@geidsonc geidsonc marked this pull request as draft March 2, 2026 17:04
@geidsonc geidsonc marked this pull request as ready for review March 2, 2026 17:04
@geidsonc
Copy link
Member Author

geidsonc commented Mar 2, 2026

@jules update this branch with master

…alidation-starting-with-5-342378906075137649
@geidsonc geidsonc merged commit b563020 into master Mar 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update isValidCns logic to include CNS starting with 5

2 participants