Fix ProgressBar alignment and spacing in aside mode#1064
Conversation
- Added 'progress-bar--aside' class to main container when 'textAside' is true - Applied 'gap: 4px' to the aside container for proper spacing - Added 'progress-bar__text--aside' class to text when 'textAside' is true - Set 'margin: 0 !important' for the aside text to ensure vertical centering - Restricted 'progress-bar__left' class to only apply when not in aside mode - Added unit test to verify the application of the new classes Co-authored-by: lucasn4s <17988272+lucasn4s@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Greptile SummaryEste PR corrige com sucesso um problema de alinhamento vertical e espaçamento no componente Principais mudanças:
A correção é focada, bem delimitada ao componente afetado e não introduz breaking changes. A lógica de classes condicionais está correta e o novo teste cobre o caso de uso principal. Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[ProgressBar renderizado] --> B{textAside?}
B -- Sim --> C[Aplica progress-bar--aside\ngap: 4px no container]
B -- Nao --> D{textLeft?}
D -- Sim --> E[Aplica progress-bar__left\nalign-items: initial]
D -- Nao --> F[Sem classe extra]
C --> G{showText?}
G -- Sim --> H[Span com progress-bar__text\n+ progress-bar__text--aside\nmargin: 0]
G -- Nao --> I[Span nao renderizado]
B -- Nao --> J{showText?}
J -- Sim --> K[Span com progress-bar__text\nmargin: mb 2]
J -- Nao --> L[Span nao renderizado]
Last reviewed commit: 46147da |
- Added 'progress-bar--aside' class to main container when 'textAside' is true. - Applied 'gap: 4px' to the aside container for proper spacing. - Added 'progress-bar__text--aside' class to text when 'textAside' is true. - Set 'margin: 0 !important' for the aside text to ensure vertical centering. - Restricted 'progress-bar__left' class to only apply when not in aside mode. - Added unit test to verify the application of the new classes. - Fixed flaky test in DateInput.spec.js by mocking system time for both Vitest and Luxon. - Updated project version in package.json. Co-authored-by: lucasn4s <17988272+lucasn4s@users.noreply.github.com>
Fixed an issue in the ProgressBar component where the progress text and the bar were vertically misaligned and lacked spacing when
showTextandtextAsideprops were active.The fix involved:
progress-bar--asideandprogress-bar__text--asideclasses.progress-bar__leftis only applied when the text is NOT in aside mode to avoid alignment conflicts.gapproperty on the flex container.src/tests/ProgressBar.spec.tsto verify the fix.PR created automatically by Jules for task 11071333345092221231 started by @lucasn4s