Skip to content

Fix locals 313 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matteobachetti merged 3 commits into from
Mar 19, 2026
Merged

Fix locals 313 #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5edf5ba
Fix issue with new locals() in Python 3.13
matteobachetti Mar 19, 2026
11b426b
Add changelog
matteobachetti Mar 19, 2026
8d8f814
Pass locals and globals as simple arguments. Should work in all allow…
matteobachetti Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changes/195.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix use of locals() which has changed behavior in Python 3.13
13 changes: 7 additions & 6 deletions hendrics/create_gti.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,16 @@ def create_gti(fname, filter_expr, safe_interval=[0, 0], outfile=None, minimum_l
mjdref = data.mjdref
# Map all entries of data to local variables
array_attrs = data.array_attrs() + ["time"]
locals().update(zip(array_attrs, [getattr(data, attr) for attr in array_attrs]))
if hasattr(data, "internal_array_attrs"):
array_attrs = data.internal_array_attrs()
mod_array_attrs = [attr.replace("_", "") for attr in array_attrs]
locals().update(zip(mod_array_attrs, [getattr(data, attr) for attr in array_attrs]))
new_array_attrs = data.internal_array_attrs()
mod_array_attrs = [attr.replace("_", "") for attr in new_array_attrs]
array_attrs += mod_array_attrs

good = eval(filter_expr)
new_locals = {attr: getattr(data, attr) for attr in array_attrs}

gti = create_gti_from_condition(locals()["time"], good, safe_interval=safe_interval)
good = eval(filter_expr, None, new_locals)

gti = create_gti_from_condition(new_locals["time"], good, safe_interval=safe_interval)

gti = filter_gti_by_length(gti, minimum_length)

Expand Down
Loading