Require an expected status code for every request#225
Open
axel-op wants to merge 4 commits intoSpinlockLabs:masterfrom
Open
Require an expected status code for every request#225axel-op wants to merge 4 commits intoSpinlockLabs:masterfrom
axel-op wants to merge 4 commits intoSpinlockLabs:masterfrom
Conversation
axel-op
changed the title
Contributor
|
I just raised an issue on this very topic then noticed your pr. Any chance this can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
request, and marks this parameter asrequired.Without it, the method silently fails, i.e. an object is returned with all values set to null...
createinpulls_service(the previous one was obsolete).orgs_serviceas the API has changed.Fixes #194.
Fixes #230.