Improve the way of importing the VERSION constant#719
Open
xsamueljr wants to merge 1 commit intoShopify:mainfrom
Open
Improve the way of importing the VERSION constant#719xsamueljr wants to merge 1 commit intoShopify:mainfrom
VERSION constant#719xsamueljr wants to merge 1 commit intoShopify:mainfrom
Conversation
Contributor
|
Thank you @xsamueljr ! Could you please sign the CLA? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When having a file with one single line declaring a constant (the
shopify.versionmodule), loading it by usingexec()is a pretty weird method. You should just import the constant instead. This improves code readability and follows best practices for importing modulesChecklist