Skip to content

Indentation fix within tasks/index.html.erb#1405

Merged
etiennebarrie merged 3 commits intoShopify:mainfrom
joshmfrankel:main
Mar 10, 2026
Merged

Indentation fix within tasks/index.html.erb#1405
etiennebarrie merged 3 commits intoShopify:mainfrom
joshmfrankel:main

Conversation

@joshmfrankel
Copy link
Contributor

@joshmfrankel joshmfrankel commented Mar 2, 2026

Why

I noticed a small indentation discrepancy and fixed it. Also excellent gem 🎉

What

  • Proper indentation on tasks/index.html.erb

@joshmfrankel joshmfrankel marked this pull request as ready for review March 2, 2026 21:19
<div class="grid is-col-min-20">
<%= render partial: 'task', collection: new_tasks %>
</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[memo]
Image

It's hard to understand in GitHub preview, there are tabs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to remove the tabs here instead of adding spaces. If you turn them into 4 spaces, it's properly aligned.

@etiennebarrie etiennebarrie mentioned this pull request Mar 5, 2026
@etiennebarrie etiennebarrie merged commit ec8b5ec into Shopify:main Mar 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants