Add failsafe and improve logging on unexpected select app error#6815
Open
alfonso-noriega wants to merge 1 commit intomainfrom
Open
Add failsafe and improve logging on unexpected select app error#6815alfonso-noriega wants to merge 1 commit intomainfrom
alfonso-noriega wants to merge 1 commit intomainfrom
Conversation
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3715 tests passing in 1438 suites. Report generated by 🧪jest coverage report action from e86c51c |
alfonso-noriega
force-pushed
the
02-03-add_failsafe_and_improve_loging_on_unexepcete_select_app_error
branch
from
ea40cf9 to
5d0894d
Compare
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
gonzaloriestra
changed the title
alfonso-noriega
force-pushed
the
02-03-add_failsafe_and_improve_loging_on_unexepcete_select_app_error
branch
2 times, most recently
from
1d3d3b1 to
75f75ba
Compare
alfonso-noriega
force-pushed
the
02-03-add_failsafe_and_improve_loging_on_unexepcete_select_app_error
branch
from
75f75ba to
e86c51c
Compare
| 'Try running the command again. If the issue persists:', | ||
| ' • Check system resources and stability', | ||
| ' • Try running outside of containers/WSL if applicable', | ||
| ' • Report this issue with the error detailsmad a verbose log', |
Contributor
There was a problem hiding this comment.
Suggested change
| ' • Report this issue with the error detailsmad a verbose log', | |
| ' • Report this issue with the error details and a verbose log', |
| `Available apps: ${apps.length}`, | ||
| ].join('\n') | ||
|
|
||
| const tryMessage = [ |
Contributor
There was a problem hiding this comment.
Can you extract this to avoid repetition?
| } else { | ||
| const tryMessage = [ | ||
| 'This may happen if:', | ||
| ' • The process received a signal (SIGINT, SIGTERM) or was terminated', |
Contributor
There was a problem hiding this comment.
If you press CTRL-C, the command should stop immediately. We shouldn't retry anything in that case.
But I'm not able to reproduce that behavior, is that happening?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Issue #771
vault error
Fixes an issue where app selection prompts could fail silently without proper error handling or diagnostics, leading to a poor developer experience when the prompt is interrupted.
WHAT is this pull request doing?
Adds robust error handling and retry logic to the app selection process:
How to test your changes?
shopify app devin a project with multiple appsMeasuring impact
How do we know this change was effective? Please choose one:
Checklist