Conversation
… configs from the remote server
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3718 tests passing in 1441 suites. Report generated by 🧪jest coverage report action from 66ef065 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
This PR fixes the issue where the identifier attribute added on the server side was causing the same events config to be marked as
updated. More details can be found in the linked issue.Fixes https://github.com/shop/issues-event-foundations/issues/763
WHAT is this pull request doing?
When redeploying the same events config, there was a bug causing it to show
updated. It should showno changes.To fix this, I added a specification for the events module in the CLI and added a transformation config, where the remote->local transformation would remove the
identifierattribute and the local->remote transformation is a no-op.How to test your changes?
See https://github.com/shop/issues-event-foundations/issues/763#issuecomment-3837542155
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist