Draft
Conversation
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3679 tests passing in 1437 suites. Report generated by 🧪jest coverage report action from cd9fc6e |
e165a9d to
5b7340f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPENDS ON https://github.com/shop/world/pull/382743 TO SHIP FIRST
WHY are these changes introduced?
Related to Hosted app project.
Related to https://github.com/shop/world/pull/382743
Closes https://github.com/shop/issues-admin-extensibility/issues/2186
WHAT is this pull request doing?
This PR introduces the asset pipeline flow for hosted static apps, enabling static asset copying during the build process.
app_config_hosted_app_home.ts): Adds a configuration extension specification for hosted apps with astatic_rootfieldstatic_appbuild mode: Extends the build config modes to includestatic_app, which triggers static asset copyingHow it works
When a hosted app defines a static_root in its configuration:
hosted_appspecification is loaded with build modestatic_appcopyStaticAssets()is invokedstatic_rootdirectory are copied to the output directoryHow to test your changes?
static_rootpointing to a static assets directoryshopify app deployand verify assets are copied to the output directory -.shopify/deploy-bundleMeasuring impact
How do we know this change was effective? Please choose one:
Checklist