fix: address output swallowing on Ubuntu 24.04 (#6726)#6800
Open
AryanKansagara wants to merge 1 commit intoShopify:mainfrom
Open
fix: address output swallowing on Ubuntu 24.04 (#6726)#6800AryanKansagara wants to merge 1 commit intoShopify:mainfrom
AryanKansagara wants to merge 1 commit intoShopify:mainfrom
Conversation
- Add explicit Writable stream options in ConcurrentOutput for cross-platform compatibility - decodeStrings: false - defaultEncoding: utf8 - highWaterMark: 16 (smaller buffer for faster data flow) - Add buffer: false to execa options in system.ts to disable output buffering - Add debug logging to trace output flow (ui.tsx, ConcurrentOutput.tsx, system.ts) - Add 3 new test cases for delayed writes, rapid consecutive writes, and mixed stdout/stderr Fixes Shopify#6726
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6726 -
shopify app devswallows server logs and rebuild output on Ubuntu 24.04Problem
On Ubuntu 24.04, users report that
shopify app devshows no terminal output even though hot reload works correctly. The terminal remains silent during server startup, file changes, and rebuilds.Solution
This PR addresses potential buffering differences between platforms by:
ConcurrentOutput.tsx - Added explicit Writable stream options:
decodeStrings: false- prevents extra buffer conversiondefaultEncoding: 'utf8'- ensures consistent encodinghighWaterMark: 16- smaller buffer for faster data flowsystem.ts - Added
buffer: falseto execa options to disable stdout/stderr buffering and ensure real-time streamingDebug logging - Added tracing to help diagnose future issues with output flow
Testing
Checklist