Encapsulate MUMPS solver class

[julianlitz]

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

• There is at least one issue associated with the pull request.
• New code adheres with the coding guidelines
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

• Tests for new functionality has been added
• A local test was succesful

If new functionality was added:

• There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

• Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

• Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

• Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
• The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
• There are appropriate unit tests and they pass.
• The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
• Coverage report for new code is acceptable.
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

[codecov]

Codecov Report

❌ Patch coverage is 96.52174% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.16%. Comparing base (39ce1dd) to head (a47f84b).

Files with missing lines	Patch %	Lines
src/LinearAlgebra/Solvers/coo_mumps_solver.cpp	95.87%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   95.18%   95.16%   -0.02%     
==========================================
  Files          94       94              
  Lines        9345     9274      -71     
==========================================
- Hits         8895     8826      -69     
+ Misses        450      448       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[EmilyBourne]

Why do you only use a .h file? Wouldn't a .cpp file reduce compilation speed?

[julianlitz]

Currently we dont have a src/LinearAlgebra folder, since everything is floating point templated there.

Mumps is an exception since it needs to be hardcoded with float or double. So here we can move things to a .cpp but maybe it is not worth it.

[EmilyBourne]

I'm not sure. Here you compile quite fast but Gysela got bogged down quite fast by using lots of templates in .hpp files. I don't know to what degree the .hpp is the problem and to what degree it is the templates. Probably the templates are the most important thing

[EmilyBourne]

Previously this was a warning but now it is an error. Does this mean that the code would crash if the solver failed to converge? Even if it was nearly converged?

[EmilyBourne]

Similar question. This has changed from a warning to a hard error right? Are we sure that this is what we want?