Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
DatasetsListService.deletedCondition, you can simplify the implementation to directly return the boolean expression (return dataset.datasetlifecycle.archiveStatusMessage === 'deleted';) instead of using anifstatement. - Now that
setFiltersActionacceptsPartial<DatasetFilters>, it may be worth tightening usage by explicitly specifying which fields are expected in each call site (e.g., via helper functions or typed wrappers), to avoid accidentally omitting or overwriting critical filter properties over time.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `DatasetsListService.deletedCondition`, you can simplify the implementation to directly return the boolean expression (`return dataset.datasetlifecycle.archiveStatusMessage === 'deleted';`) instead of using an `if` statement.
- Now that `setFiltersAction` accepts `Partial<DatasetFilters>`, it may be worth tightening usage by explicitly specifying which fields are expected in each call site (e.g., via helper functions or typed wrappers), to avoid accidentally omitting or overwriting critical filter properties over time.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Address sourcery comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It adds a deleted view fetching from "datasetLifecycle.archiveStatusMessage": "deleted", when jobs are enabled
It also improves the breadcrumb removing code duplication and reusing the RxJS reducer as well as avoiding to override the skip
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Add a deleted archive view mode for datasets and reuse centralized filter state when navigating via breadcrumbs and archive mode controls.
New Features:
Enhancements:
Tests: