Open
Conversation
…o published_data_schema_update
HayenNico
requested changes
Apr 10, 2026
Member
HayenNico
left a comment
HayenNico
left a comment
There was a problem hiding this comment.
The code looks fine, but I think we should not make the datasetPids field optional at this time. The DOI registration at DataCite is currently hardcoded to use Dataset as the resourceTypeGeneral (see e.g. here in the v4 controller). This is not suitable if a PublishedData instance were to include only samples or proposals.
It would be fine to add links to sample and proposal documents under a publishedData instance so long as these do not have their own DOIs (standalone sample DOI publications should for example use IGSNs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fields to store proposals and samples in the published data record.
Motivation
Some data policies requires that a DOi is assigned to the whole proposal as soon as it is approved. This PR will allow to assign and register a new DOI as soon as a proposal is accepted and saved in SciCat.
Also, more and more, DOI can be register for a non homogeneous group of information which can contain proposals, samples and datasets alike.
Changes:
Tests included
N/A
Documentation