Open
Conversation
dontlaugh
previously approved these changes
Feb 26, 2026
bpapillon
reviewed
Feb 27, 2026
| logger, | ||
| offline, | ||
| }); | ||
| this.flagCheckCacheProviders = opts?.cacheProviders?.flagChecks ?? [new LocalCache<boolean>()]; |
Contributor
There was a problem hiding this comment.
by removeing the boolean cache - don't we break the Cloudflare KV setup? unless we also add support for Cloudflare KV to cache entitlement responses as well here?
Contributor
Author
There was a problem hiding this comment.
the cloudflare library is just another cache provider, it doesn't specify the type of object that is cached. so any existing consumers of it would just set it up the same way they would a redis cache.
Contributor
Author
There was a problem hiding this comment.
though that reminds me i should update the readmes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.