Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch adds Load from SASBDB: users can enter a SASBDB dataset ID, fetch metadata and intensity data from the SASBDB REST API, download a local copy, load it through the existing File data pipeline, and enrich the loaded
Data1Dobjects with SASBDB-derived metadata (sample, instrument, publication, Rg, I(0), Dmax, MW, etc.) where the API provides them.Implementation highlights
sasbdb_api: HTTP client forhttps://www.sasbdb.org/rest-apiusingrequests— metadata fetch, URL discovery for intensity files, streamed download to a temp path, robust parsing intoSASBDBDatasetInfo(dataclass).SASBDBDownloadDialog: Simple UI (dataset ID, Download, progress, status, Help/Cancel); on success returns filepath + parsed info for loading.GuiManager.actionLoad_SASBDB: Wired from File → Load from SASBDB (MainWindowUI.ui); callsfilesWidget.readData, then_populateSASBDBMetadatato merge API fields intodata.sample,data.run,data.instrument,data.title, andmeta_data['SASBDB_*']keys for downstream display.GuiUtils: Extends dataset summary text (e.g. Data Explorer / details) with a SASBDB metadata block whenSASBDB_code(and related keys) are present.sasbdb_download_help.rst.Dependencies
requests(already listed inbuild_tools/requirements.txtfor the project).How Has This Been Tested?
sasbdb_api/ download dialog were added on this branch; consider mocking HTTP for CI in a follow-up.Review Checklist
Sample/Source/meta_datakeys do not break loaders or perspectives.SASBDBDownloadDialogUI.uiis accompanied by regenerated Python UI (convertUI.py/ project build) if required.menu_bar.rst,tools.rst,sasbdb_download_help.rst) matches the menu label and workflow.requestsremains available in the installed dependency set for end users (not only dev tooling).Documentation (check at least one)
Installers
Licensing (untick if necessary)