Draft
Conversation
…mple_visualizer
Contributor
|
This is a lot of code to maintain. Can you instead create a 3d model representation for each shape and use other tools for meshing and cross sections? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 3D shape visualization for sasmodels: models can declare support, build meshes from form-factor parameters, and callers can render figures for docs and reports.
Relation to SASBDB
This work supports SASBDB report functionality on SasView (SasView/sasview#3912)
Changes
Dependencies
Visualization uses matplotlib and numpy; suitable for optional explore tooling and opt-in image generation in applications.