Skip to content

Add black theme#437

Draft
Elec3137 wants to merge 1 commit intoSableClient:devfrom
Elec3137:add-black-theme
Draft

Add black theme#437
Elec3137 wants to merge 1 commit intoSableClient:devfrom
Elec3137:add-black-theme

Conversation

@Elec3137
Copy link

Description

Adds a black theme (high contrast dark theme)

However, it's currently not showing up as an option, so probably I missed something. (I used 7w1/sable@6f2d630 as a reference of how to do this, perhaps it is outdated?)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Contributor

@dozro dozro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: lgtm

but you have to run prettier, noticed some ghost changes (new lines, and spacing) that might have caused this

@Elec3137
Copy link
Author

but you have to run prettier, noticed some ghost changes (new lines, and spacing) that might have caused this

Sorry about that, should've looked closer. vscode-css-languagerserver seems to automatically remove the trailing newline for some reason. As well as a lot of other random stuff. oops...

@dozro
Copy link
Contributor

dozro commented Mar 20, 2026

Is this still a WIP or ready for review?

@Elec3137
Copy link
Author

Elec3137 commented Mar 20, 2026

Is this still a WIP or ready for review?

Still WIP because I've not been able to properly test it. I keep running into OOMs now on nixos, trying to make sense of things.

on pnpm run build:

[6534:0x56219437a000]    18341 ms: Mark-Compact 2028.1 (2056.7) -> 2022.7 (2060.4) MB, pooled: 0 MB, 469.08 / 0.00 ms  (average mu = 0.273, current mu = 0.190) allocation failure; scavenge might not succeed
[6534:0x56219437a000]    18883 ms: Mark-Compact 2031.3 (2061.0) -> 2027.8 (2081.5) MB, pooled: 0 MB, 509.94 / 0.00 ms  (average mu = 0.172, current mu = 0.059) allocation failure; scavenge might not succeed

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0x56215c521040 node::OOMErrorHandler(char const*, v8::OOMDetails const&) [node]
 2: 0x56215c9f8170  [node]
 3: 0x56215c9f8276  [node]
 4: 0x56215cceef97  [node]
 5: 0x56215cd03f9d  [node]
 6: 0x56215ccd109b  [node]
 7: 0x56215cca2bca  [node]
 8: 0x56215d24b8af  [node]
 9: 0x7fb7c7e76636 

@dozro
Copy link
Contributor

dozro commented Mar 20, 2026

happens to me if i build sable with cloudflare too, idk why building takes that much memory, might be worth looking into at some point

@Elec3137
Copy link
Author

happens to me if i build sable with cloudflare too, idk why building takes that much memory, might be worth looking into at some point

In case this helps anyone, I fixed my problem by invoking vite build like so:

node --max-old-space-size=8192 node_modules/vite/bin/vite.js build

source: vitejs/vite#2433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants