fix: suppress unread dot for rooms set to Mute#429
Open
saschabuehrle wants to merge 2 commits intoSableClient:devfrom
Open
fix: suppress unread dot for rooms set to Mute#429saschabuehrle wants to merge 2 commits intoSableClient:devfrom
saschabuehrle wants to merge 2 commits intoSableClient:devfrom
Conversation
Member
|
Looks good! Please create a changeset file and I'll merge it in! |
7w1
approved these changes
Mar 20, 2026
Author
|
Thanks for the review. I added the requested changeset file in this branch:\n- .changeset/fix-muted-room-unread-indicator.md\n\nPlease take another look when you have a moment.\n\nGreetings, saschabuehrle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #395 — muted rooms still showed unread dot/highlight even when notification mode was set to Mute.
Fix
RoomNavItem.shouldShowUnreadIndicatorguard that requires:RoomNotificationMode.MuteunreadorhasRoomUnread)This keeps muted rooms visually quiet in the room list while preserving unread behavior for non-muted rooms.
Testing
src/app/features/room-nav/RoomNavItem.tsxfor both muted and non-muted room notification modes.Greetings, saschabuehrle