Skip to content

fix: suppress unread dot for rooms set to Mute#429

Open
saschabuehrle wants to merge 2 commits intoSableClient:devfrom
saschabuehrle:fix/issue-395-hide-muted-unread-dot
Open

fix: suppress unread dot for rooms set to Mute#429
saschabuehrle wants to merge 2 commits intoSableClient:devfrom
saschabuehrle:fix/issue-395-hide-muted-unread-dot

Conversation

@saschabuehrle
Copy link

Bug

Fixes #395 — muted rooms still showed unread dot/highlight even when notification mode was set to Mute.

Fix

  • Added explicit muted-room check in RoomNavItem.
  • Introduced shouldShowUnreadIndicator guard that requires:
    • room is not in RoomNotificationMode.Mute
    • room has unread data (unread or hasRoomUnread)
  • Applied this guard to:
    • room row highlight state
    • unread badge/dot rendering

This keeps muted rooms visually quiet in the room list while preserving unread behavior for non-muted rooms.

Testing

  • Verified logic path in src/app/features/room-nav/RoomNavItem.tsx for both muted and non-muted room notification modes.

Greetings, saschabuehrle

@saschabuehrle saschabuehrle requested review from 7w1 and hazre as code owners March 20, 2026 14:47
@7w1
Copy link
Member

7w1 commented Mar 20, 2026

Looks good! Please create a changeset file and I'll merge it in!

@saschabuehrle
Copy link
Author

Thanks for the review. I added the requested changeset file in this branch:\n- .changeset/fix-muted-room-unread-indicator.md\n\nPlease take another look when you have a moment.\n\nGreetings, saschabuehrle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Muted rooms showing the notification dot for unread messages

2 participants