Open
Conversation
1주차 미션1 완료
yewon20804
reviewed
Apr 7, 2026
| setIsError(false); | ||
|
|
||
| try { | ||
| const movieResponse = await axios.get<MovieDetail>( |
Collaborator
There was a problem hiding this comment.
현재 movieResponse와 creditsResponse를 순차적으로 호출하고 있는데,
이 두 API는 서로 독립적이므로 병렬 처리하면 두 api가 동시헤 호출되어 소요 시간이 더 짧아집니다:)
const [movieResponse, creditsResponse] = await Promise.all([
axios.get<MovieDetail>(
`https://api.themoviedb.org/3/movie/${movieId}?language=ko-KR`,
{
headers: {
Authorization: `Bearer ${import.meta.env.VITE_TMDB_KEY}`,
},
}
),
axios.get<Credits>(
`https://api.themoviedb.org/3/movie/${movieId}/credits?language=ko-KR`,
{
headers: {
Authorization: `Bearer ${import.meta.env.VITE_TMDB_KEY}`,
},
}
),
]);
...
yewon20804
reviewed
Apr 7, 2026
| 영화 정보를 불러올 수 없습니다. | ||
| </p> | ||
| <p className='text-gray-400 mb-6'>다시 시도해주세요.</p> | ||
| <button |
Collaborator
There was a problem hiding this comment.
뒤로 가기 버튼 만는거 너무 좋은 것 같아요 👍
yewon20804
reviewed
Apr 7, 2026
| )} | ||
| </div> | ||
|
|
||
| <style>{` |
Collaborator
There was a problem hiding this comment.
JSX 내부에 style 태그를 직접 작성해주셨는데, 해당 방식 보다는 index.css와 같은 스타일 파일로 분리하여 관리하는 것이 더 좋습니다 !
yewon20804
reviewed
Apr 7, 2026
Collaborator
yewon20804
left a comment
There was a problem hiding this comment.
미션 3도 수고 많으셨습니다! 😊
상세 페이지를 구현해보는 미션이였는데, 타입 정의도 잘해주셨고, 스타일 작성 시 데이터가 없는 경우에 대한 예외 처리까지 신경 써주신 부분도 좋았습니다 👍 리뷰 확인 부탁드립니다 ~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 주차 / 미션
---영화 목록 페이지 구현
📌 작업 내용
---useParams를 활용한 영화 상세 페이지 개발
✨ 상세 작업 내용
📸 스크린샷
❓ 리뷰어가 알아야 할 사항 / 질문
✅ 체크리스트