Open
Conversation
Collaborator
|
수고하셨습니다! |
Collaborator
|
고생하셨습니당~! |
yangjiae12
approved these changes
Apr 13, 2026
Member
yangjiae12
left a comment
yangjiae12
left a comment
There was a problem hiding this comment.
사용자 도메인 외에는 추후 미션 진행할 때 파일 추가해서 하시면 좋을 것 같습니다! 수고하셨습니다~
Member
There was a problem hiding this comment.
User에 필요한 Enum도 추가해서 만들면 좋을 것 같아요! (gender, social type 등)
Member
There was a problem hiding this comment.
Service와 Impl을 인터페이스로 분리하신 거 좋은 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
다음엔 이슈파서 할게여
📌 구현 결과
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항