Fix multi-domain group p-value display cross-domain bleed#2524
Merged
akenmorris merged 1 commit intomasterfrom Mar 25, 2026
Merged
Fix multi-domain group p-value display cross-domain bleed#2524akenmorris merged 1 commit intomasterfrom
akenmorris merged 1 commit intomasterfrom
Conversation
Shape::set_point_features() to prevent cross-domain bleed in KD-tree interpolation. Previously, all particles from all domains were passed to each mesh, causing neighboring domain p-values to corrupt the display near anatomically close regions (e.g., femur/pelvis at the hip joint). Also use a fixed RandomState seed in stats.py for reproducible p-values across runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split particles and scalar values per domain in Shape::set_point_features() to prevent cross-domain bleed in KD-tree interpolation. Previously, all particles from all domains were passed to each mesh, causing neighboring domain p-values to corrupt the display near anatomically close regions (e.g., femur/pelvis at the hip joint).
Also use a fixed RandomState seed in stats.py for reproducible p-values across runs.
Before:
After fixes: