Declare Builder mixin methods as static for static analysis support#16
Merged
henriquemoody merged 5 commits intomainfrom Feb 7, 2026
Merged
Conversation
Co-authored-by: henriquemoody <154023+henriquemoody@users.noreply.github.com>
Co-authored-by: henriquemoody <154023+henriquemoody@users.noreply.github.com>
Co-authored-by: henriquemoody <154023+henriquemoody@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Builder interface methods to be static for static analysis
Declare Builder mixin methods as static for static analysis support
Feb 6, 2026
henriquemoody
requested changes
Feb 7, 2026
composer.json
Outdated
| }, | ||
| "sort-packages": true | ||
| "sort-packages": true, | ||
| "platform-check": false |
Co-authored-by: henriquemoody <154023+henriquemoody@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=========================================
Coverage 99.47% 99.47%
Complexity 163 163
=========================================
Files 24 24
Lines 382 382
=========================================
Hits 380 380
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to Fix Builder Interface Static Methods
Summary
Successfully resolved the issue where static analysis tools couldn't discover static method calls on
FormatterBuilderby updating theBuildermixin interface.Changes Made
src/Mixin/Builder.php: Changed all 12 method declarations frompublic functiontopublic static functionto match the actual usage pattern via__callStaticmagic method. This enables PHPStan, Psalm, and IDE autocomplete to properly discover and validate static method calls likeFormatterBuilder::mask('1-3')..gitignore: Added.phpunit.result.cacheto prevent test execution artifacts from being committed.Key Points
FormatterBuilder::method()calls$builder->method()Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.