Fix: Light Mode Styling Not Applying on FAQ Page#1001
Merged
Renu-code123 merged 2 commits intoRenu-code123:mainfrom Mar 5, 2026
Merged
Fix: Light Mode Styling Not Applying on FAQ Page#1001Renu-code123 merged 2 commits intoRenu-code123:mainfrom
Renu-code123 merged 2 commits intoRenu-code123:mainfrom
Conversation
|
@Eshajha19 is attempting to deploy a commit to the Renu's projects Team on Vercel. A member of the Team first needs to authorize it. |
🎉 Thanks for the PR, @Eshajha19!We really appreciate you taking the time to contribute to ExpenseFlow! 💙 ⭐ Love this project?Please give us a star! It helps the project grow and reach more developers! 🌟 🔗 https://github.com/Renu-code123/ExpenseFlow ✅ PR ChecklistBefore we review, please ensure:
🙌 Thank You for Contributing!We truly appreciate your interest in contributing to this project.
We'll review your PR as soon as possible. Keep up the great work! ✨ |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Light Mode Styling Not Applying on FAQ Page
Overview
This PR fixes an issue where enabling Light Mode on the FAQ page only changed the toggle button but did not update the page background and overall theme.
Problem
The theme toggle correctly switched the icon.
However, the page background and text colors remained in dark mode.
This happened because global elements like body, navbar, and footer did not have proper light-theme overrides.
Changes Made
Added global light mode styles for key layout components:
body
.navbar
.footer
.nav-link
.category-btn
.faq-item
Ensured the background switches to white and text colors adjust accordingly when data-theme="light" is applied.
Improved visual consistency between dark and light themes.
Result
Light mode now properly updates:
Page background
Navigation bar
FAQ items
Category buttons
Footer
Theme toggle works as expected across the page.
Impact
Fixes UI inconsistency
Improves accessibility and readability
Maintains the existing layout and styling structure
This PR closes issue #997
Screen.Recording.2026-03-05.132340.mp4