Add setting for optional zip compression (different approach)#244
Open
DisabledMallis wants to merge 1 commit intoReClassNET:masterfrom
Open
Add setting for optional zip compression (different approach)#244DisabledMallis wants to merge 1 commit intoReClassNET:masterfrom
DisabledMallis wants to merge 1 commit intoReClassNET:masterfrom
Conversation
This is useful when the ReClass.NET project is in a git repository and multiple people are working on it at once. Git software often cannot merge ZIP archives, and thus cannot merge rcnet project files. Having the ability to save the project without compression can solve this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create a new one called ReClassDataFile. Enabling/Disabling the "Compress as ZIP" under a new "Project Settings" tab will enable/disable the use of ReClassDataFile over ReClassNetFile. The benefit of using a new class to implement the feature is that it continues to follow the current code format/style, whereas just modifying the ReClassNetFile class directly could encourage code to become a little 'messy'.
There are some more things I should probably fix/change to make this a better suited PR for merging, such as: