Use ParseViaFramework constructor parameter rather than via property#19
Open
erenes wants to merge 2 commits intoRamblingCookieMonster:masterfrom
Open
Use ParseViaFramework constructor parameter rather than via property#19erenes wants to merge 2 commits intoRamblingCookieMonster:masterfrom
erenes wants to merge 2 commits intoRamblingCookieMonster:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this module, I got an error about the property "ParseViaFramework". When reviewing documentation, I found that there is also a constructor parameter for the same property in SQLiteConnection, this does not throw an error on my machine. I was still able to open a database on a UNC path (starting with \servername), so I think this does not introduce a regression.
Additionally, the test failed on my end because I don't use the American date format, so I made that test slightly more robust as well.