Skip to content

136 support higher pandas versions#137

Merged
FelixStege merged 3 commits intomainfrom
136-support-higher-pandas-versions
Mar 6, 2026
Merged

136 support higher pandas versions#137
FelixStege merged 3 commits intomainfrom
136-support-higher-pandas-versions

Conversation

@FelixStege
Copy link
Contributor

Thank you for making a Pull Request to BESMod!

Please consider these points before submitting:

  • Mention the issue that this Pull Request intends to solve, and briefly describe what the main changes are.
  • Make sure all new code follows our Modelica Guidelines
  • Make sure all new models include documentation as described in the Documentation Wiki-Page and are demonstrated by suitable examples

If you know someone who could review your code, please use the Reviewer function on the right to ask for a review and also assign the PR to them. If not, no worries, we will find someone for you.

Thanks again for your PR! You can delete these first lines before submitting your PR.

@FelixStege FelixStege self-assigned this Mar 6, 2026
@FelixStege FelixStege linked an issue Mar 6, 2026 that may be closed by this pull request
@FelixStege FelixStege requested a review from HvanderStok March 6, 2026 11:06
@ebc-aixlib-bot
Copy link

Thank you for making a Pull Request to BESMod!

Our CI pipeline will help you finalize your contribution.
Here's what is typically checked:

  • HTML syntax of your models, primarily in your documentation.
  • Adherence to the naming convention in all changed files.
  • Ability to check all models.
  • Ability to simulate all models, if they are examples.
  • If your contribution changes existing reference results.

If HTML errors occur, I will fix the issues using a separate pull request.
For the other checks, I will post the results here: https://rwth-ebc.github.io/BESMod/136-support-higher-pandas-versions/index.html

Tips to fix possible naming violations:

  • Stick to the naming guidelines, e.g. Namespace Requirements
  • Do all paramaters, variables, models, etc. have a description?
  • Use absolute paths to classes! -> BESMod.Fluid.HeatExchangers.Radiator - Avoid: HeatExchangers.Radiator

If all CI stages pass and you have addressed possible naming violations, please consider the following:

  • Use "group" and "tab" annotations to achieve a good visualization window.
  • Use units consistently.
  • Instantiate the replaceable medium package as:
    replaceable package Medium = Modelica.Media.Interfaces.PartialMedium "Medium model";
    instead of using a full media model like BESMod.Media.Water directly.
  • Never using absolute paths to files (e.g., C: or D:). Replace them with modelica://BESMod/....
  • Ensure your documentation is helpful and concise.
  • Make sure icons are clear. Please avoid using images!
  • Stick to 80 characters per line, as long as it makes sense.
  • Add or modify examples for new or revised models.
  • Include a simulate-and-plot script as a regression test for new models.
    How? Follow the documentation here: https://github.com/ibpsa/modelica-ibpsa/wiki/Unit-Tests#how-to-include-models-as-part-of-the-unit-tests
    Tip: To create the initial script, you can use Dymolas script generator, explained here: https://www.claytex.com/tech-blog/how-to-use-a-plot-script/)

Once you have addressed these points, you can assign a reviewer.
Although this process may seem tedious, ensuring CI passes allows the reviewer to focus
their time on the actual modeling rather than syntax and unintended breakages caused by your changes.

If you have any questions or issues, please tag a library developer.
Once again, thank you for your valuable contribution!

@FelixStege FelixStege merged commit ebffa52 into main Mar 6, 2026
@FelixStege FelixStege deleted the 136-support-higher-pandas-versions branch March 6, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support higher pandas versions

3 participants