Conversation
kshyatt
force-pushed
the
orthnull-diag
branch
3 times, most recently
from
866b350 to
d07f57d
Compare
kshyatt
force-pushed
the
orthnull-diag
branch
from
d07f57d to
c5a977f
Compare
Member
Author
|
OK, I think we finally got it lol. Passed locally on an AMDGPU for me. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Member
Author
|
GPU test fail here is the CUDA mempool thing unrelated to us |
Member
|
Can you rebase; it now shows all the changes from #128 as well, which makes it hard to see if anything was changed there. |
Member
Author
|
All rebased! |
lkdvos
reviewed
Mar 20, 2026
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
approved these changes
Mar 20, 2026
Jutho
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes up some missing methods. Needs #128 first.