Merged
Conversation
JohanMabille
force-pushed
the
mv_command
branch
from
0447999 to
29071fc
Compare
SandrineP
reviewed
Feb 6, 2026
test/test_mv.py
Outdated
| status_cmd = [git2cpp_path, "status", "--long"] | ||
| p_status = subprocess.run(status_cmd, capture_output=True, cwd=xtl_path, text=True) | ||
| assert p_status.returncode == 0 | ||
| assert "renamed:" in p_status.stdout or "renamed_file.txt" in p_status.stdout |
Collaborator
There was a problem hiding this comment.
It should be "and" instead of "or", but it wouldn't pass at the moment with git2cpp as there is an issue with the status (it shows a new file and a deleted file instead of a renamed one). So I would change this test and write a TODO to change it after the status command is updated.
| # Check git status | ||
| status_cmd = [git2cpp_path, "status", "--long"] | ||
| p_status = subprocess.run(status_cmd, capture_output=True, cwd=xtl_path, text=True) | ||
| assert p_status.returncode == 0 |
Collaborator
There was a problem hiding this comment.
You don't check anything in the output here.
| assert (xtl_path / "moved.txt").exists() | ||
|
|
||
|
|
||
| def test_mv_nogit(git2cpp_path, tmp_path): |
Collaborator
There was a problem hiding this comment.
Looking at Ian's last merged PR, there is something to add in this one to test in wasm.
JohanMabille
force-pushed
the
mv_command
branch
from
29071fc to
b962107
Compare
SandrineP
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.