Skip to content

fix(cluster-header-logs): add additional information#2550

Open
RemiBonnet wants to merge 3 commits intonew-navigationfrom
fix/new-nav/cluster-logs
Open

fix(cluster-header-logs): add additional information#2550
RemiBonnet wants to merge 3 commits intonew-navigationfrom
fix/new-nav/cluster-logs

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Mar 27, 2026

Summary

https://qovery.slack.com/archives/C0AML0VDUV8/p1774518915288869

  • Add additional information to the cluster logs view (threads here and here)
  • Remove the ‎onClick handler from rows in the environment deployment list to be able to copy-paste the ‎execution_id, and to be consistent with the service deployment list.

Screenshots / Recordings

image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

The backlog never ends, be at peace with it

@RemiBonnet RemiBonnet changed the title Fix/new nav/cluster logs fix(cluster-header-logs): add infos Mar 27, 2026
@RemiBonnet RemiBonnet marked this pull request as ready for review March 27, 2026 13:08
@RemiBonnet RemiBonnet changed the title fix(cluster-header-logs): add infos fix(cluster-header-logs): add additional information Mar 27, 2026
@RemiBonnet RemiBonnet added the V5 label Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@d33d798). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...r-logs/cluster-header-logs/cluster-header-logs.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2550   +/-   ##
=================================================
  Coverage                  ?   45.47%           
=================================================
  Files                     ?      696           
  Lines                     ?    16149           
  Branches                  ?     4801           
=================================================
  Hits                      ?     7344           
  Misses                    ?     7465           
  Partials                  ?     1340           
Flag Coverage Δ
unittests 45.47% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

</Tooltip>
<Tooltip side="bottom" content={<span>Execution id: {lastExecutionId}</span>}>
<span className="flex items-center gap-1.5 truncate">
<Icon iconName="code" iconStyle="regular" className="text-base text-neutral-subtle" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Icon iconName="code" iconStyle="regular" className="text-base text-neutral-subtle" />
<Icon iconName="code" iconStyle="regular" className="text-sm text-neutral-subtle" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I'm even wondering if we should not just have the execution id in the same small "tag" as the cluster version, could be even more clean

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants