Skip to content

feat(argocd): design prototype#2531

Draft
TheoGrandin74 wants to merge 9 commits intonew-navigationfrom
design/argo-cd
Draft

feat(argocd): design prototype#2531
TheoGrandin74 wants to merge 9 commits intonew-navigationfrom
design/argo-cd

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Help yourself at 2AM by putting some metrics to help observability

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 67.64706% with 33 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@556c611). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...argocd-integration/settings-argocd-integration.tsx 72.60% 17 Missing and 3 partials ⚠️
...ttings-argocd-integration/connect-argocd-modal.tsx 50.00% 12 Missing ⚠️
...-table/environment-section/environment-section.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2531   +/-   ##
=================================================
  Coverage                  ?   44.07%           
=================================================
  Files                     ?     1059           
  Lines                     ?    21339           
  Branches                  ?     6189           
=================================================
  Hits                      ?     9406           
  Misses                    ?    10243           
  Partials                  ?     1690           
Flag Coverage Δ
unittests 44.07% <67.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd added the V5 label Mar 24, 2026
…ironment overview with ArgoCD service handling
@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 24, 2026

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
29150373 Triggered Generic High Entropy Secret 8326b4d libs/domains/organizations/feature/src/lib/settings-argocd-integration/connect-argocd-modal.spec.tsx View secret
29150373 Triggered Generic High Entropy Secret 8326b4d libs/domains/organizations/feature/src/lib/settings-argocd-integration/settings-argocd-integration.spec.tsx View secret
29150373 Triggered Generic High Entropy Secret 8326b4d libs/domains/organizations/feature/src/lib/settings-argocd-integration/settings-argocd-integration.tsx View secret
29150373 Triggered Generic High Entropy Secret 8326b4d libs/domains/organizations/feature/src/lib/settings-argocd-integration/settings-argocd-integration.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants