Conversation
|
Is there a special reason why you delete the daq_2Dviewer_BaslerWithLECO.py file? For the rest of the PR, someone else has to take a look. |
|
Hello @BenediktBurger I made the judgement that the way that it was written was a bit too specific to the needs of our lab group and the way we were using LECO in our global DAQ scheme. I would like to include it again, but it should be rewritten so as to be generalized first. |
|
Hi Christian, good catch (even though, which kind of madman runs dashboards without trying a daq_viewer first??) |
|
Indeed, I had not imagined anyone creating a dashboard before testing the camera with a daq_viewer :P The patch works for me in a fresh environment with the latest PyMoDAQ release (on Python 3.11), so I would say it is fine to merge. Of course, feel free to test it yourself if you'd like to make sure. |
My colleague pointed out a bug regarding the new pop-up window for the creation of default config files. If you had never created a config file, and you create a dashboard preset with a Basler set up to auto-initialize, then PyMoDAQ will hang with just the logo showing. It turns out the pop-up window was being hidden behind the PyMoDAQ logo.
This was easily fixed in Windows by adding the appropriate flag for the window to be "top-most." In Linux, this is another issue. Any attempt in dealing with this behavior would regularly lead to segfaults. It seems to be a conflict with the re-painting of the PyMoDAQ logo during the dashboard initialization and the pop-up window, which is blocking. In fact, it is because we are creating this window from a non-GUI thread. This is tolerated in Windows since the pop-up creation does not touch Qt. However, there is no straightforward solution to this issue at the plugin level for Linux. Therefore, I opted to have the config file created by default if none exists for Linux users, with no pop-up windows.
Let me know what you guys think.