Skip to content

Update README.md#29

Open
johnjp76 wants to merge 1 commit intoProperDocs:masterfrom
johnjp76:patch-1
Open

Update README.md#29
johnjp76 wants to merge 1 commit intoProperDocs:masterfrom
johnjp76:patch-1

Conversation

@johnjp76
Copy link

remove downgrite gorgeus and make more helpfulp

Copy link
Contributor

@Andre601 Andre601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes I would like to see addressed.

@@ -1,60 +1,70 @@
# ProperDocs
## ProperDocs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see where changing this from h1 to h2 is any better.

* YAML-based configuration
* Plugin system for extending functionality
* Support for Markdown extensions
* Built-in themes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer the case. Themes are by default not included anymore and separate.

- For questions and high-level discussions, use **[Discussions]** on GitHub.
- For small questions, a good alternative is the **[Chat room]** on
Gitter/Matrix.
- For small questions, a good alternative is the **[Chat room]** on Gitter/Matrix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use Gitter or Matrix, but Discord.


## License

ProperDocs is distributed under the **BSD-2-Clause license**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the file.

Suggested change
ProperDocs is distributed under the **BSD-2-Clause license**.
ProperDocs is distributed under the [**BSD-2-Clause license**](LICENSE).


Everyone interacting in the ProperDocs project's codebases, issue trackers, and
discussion forums is expected to follow the [PyPA Code of Conduct].
All participants in the ProperDocs project are expected to follow the **PyPA Code of Conduct**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyPA no longer has its own Code of Conduct and moved to the PSF Code of Conduct (Which ironically uses the Material theme and by extension MkDocs, so maybe we can convince them to move?)

Based on this info

Also, we should either adobt our own Code of Conduct, or link and name the PSF one here instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants