Skip to content

feat(labels): add gateway.selectorLabels with component label #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camjay wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −3
Open

feat(labels): add gateway.selectorLabels with component label #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a1c71
feat(labels): add gateway.selectorLabels with component label
Mar 24, 2026
f19a6b7
Update charts/portkey-gateway/templates/_helpers.tpl
camjay Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion charts/portkey-gateway/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,25 @@ app.kubernetes.io/instance: {{ .Release.Name }}
{{- end }}
{{- end }}

{{/*
Gateway selector labels — adds component label for pod metadata and Service
selectors. Deployment matchLabels uses portkeyenterprise.selectorLabels
(without component) to avoid requiring Deployment recreation on upgrade.
*/}}
{{- define "gateway.selectorLabels" -}}
{{ include "portkeyenterprise.selectorLabels" . }}
{{- $selectorLabels := default (dict) .Values.selectorLabels -}}
{{- if not (hasKey $selectorLabels "app.kubernetes.io/component") }}
app.kubernetes.io/component: gateway
{{- end }}
{{- end }}

{{/*
Gateway labels
*/}}
{{- define "gateway.labels" -}}
{{- include "portkeyenterprise.labels" . | nindent 4 }}
{{- include "portkeyenterprise.selectorLabels" . | nindent 4 }}
{{- include "gateway.selectorLabels" . | nindent 4 }}
{{- end }}

{{/*
Expand Down
4 changes: 2 additions & 2 deletions charts/portkey-gateway/templates/gateway/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
name: mcp
{{- end }}
selector:
{{- include "portkeyenterprise.selectorLabels" . | nindent 4 }}
{{- include "gateway.selectorLabels" . | nindent 4 }}
---
{{- if and .Values.mcpService.enabled (eq (include "mcp.enabled" .) "true") }}
apiVersion: v1
Expand All @@ -47,5 +47,5 @@ spec:
protocol: TCP
name: mcp
selector:
{{- include "portkeyenterprise.selectorLabels" . | nindent 4 }}
{{- include "gateway.selectorLabels" . | nindent 4 }}
{{- end }}