Proof of concept of MVVM refactoring: ruler#2003
Open
Lehonti wants to merge 2 commits intoPintaProject:masterfrom
Open
Proof of concept of MVVM refactoring: ruler#2003Lehonti wants to merge 2 commits intoPintaProject:masterfrom
Lehonti wants to merge 2 commits intoPintaProject:masterfrom
Conversation
Contributor
|
I have a comment but won't be able to write it down until later today. Do you mind holding this back a bit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1879
This is a rough demo of how I imagine the refactoring to MVVM would go. A few explanations:
RulerModelis in thePinta.CoreprojectRulerModelmight look boring and/or pointless, but the reason is that it does not need to be more complex. The model in MVVM does not notify listeners, or knows anything about how it will be rendered. Its only job is to guard internal state consistency.double.NaNtoPosition, or something like(MetricType)992635toMetric, but I think that it's quite safe in general.PintaEngineorPintaKernelthat can hold the entirety of the internal state of Pinta without even needing to reference GUI libraries to function (although, practically, it would need to reference Cairo)