Skip to content

fix(9413): Changed mods available for The Queen's Hunger and changed veiled mods to display as crafted.#9455

Open
michelrtm wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
michelrtm:9413-queens-hunger-veiled-mod
Open

fix(9413): Changed mods available for The Queen's Hunger and changed veiled mods to display as crafted.#9455
michelrtm wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
michelrtm:9413-queens-hunger-veiled-mod

Conversation

@michelrtm
Copy link
Contributor

Fixes #9413 .

Description of the problem being solved:

In 3.26 the item "The Queen's Hunger" would pull random Prefix and Suffixes from the ordinary pool. This doesn't seem to be the case in 3.27 according to the POE Wiki Entry. As reported in the issue, a few mods were missing and a few don't seem to be available in the mod pool.

I couldn't find a prettier way to include all the mods that should display in the dropdowns, so I added the mod pool manually for the item.

Steps taken to verify a working solution:

  • Create a new build
  • Go to the items tab and select The Queen's Hunger to add to the build
  • Check that the available Prefixes and Suffixed match the expected mod pool

Link to a build that showcases this PR:

N/A as it's simple to set up.

Before screenshot:

Missing prefixes.
image

After screenshot:

Offering modifiers now available as an option and other missing prefixes are added.
image

Comment on lines 55 to 61
for index, value in ipairs(table) do
if value == lookup then
return true
end
end

return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use TAB indents only. (Line 200 also)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely missed this, pushed changes to fix this.

Comment on lines +974 to +979
[[Replica Dragonfang's Flight
Onyx Amulet
Selected Variant: 2
Has Alt Variant: true
Selected Alt Variant: 3
LevelReq: 56
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some additional spaces in the file, converted to tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Queen's Hunger Katarina mods

2 participants