-
Notifications
You must be signed in to change notification settings - Fork 61
feat: v0 tab completion #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Changes from all commits
c12c33b
324e602
9a4b2d4
4992a04
5592197
bc942c3
72167c5
05abfd7
d688433
56260eb
d8fd357
f453065
ac64b91
b6cf906
13e8553
672e569
99243ca
1ff6a69
888b66b
60421cb
a54d354
65cf022
2a00ddc
71e7c3f
f049902
cc43f36
2faa944
21d89f6
8b7ae4c
dc79e9c
0dacb49
5f6f7b8
f1c82af
4f6b8c9
6cdc60f
ebdb3d1
bae5318
90140df
aeaff3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,3 +50,6 @@ overleaf.kubeconfig | |
| # coverage report | ||
| coverage.out | ||
| coverage.html | ||
|
|
||
| # claude code | ||
| CLAUDE.md | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package chat | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "paperdebugger/internal/libs/contextutil" | ||
| "paperdebugger/internal/models" | ||
| chatv2 "paperdebugger/pkg/gen/api/chat/v2" | ||
| ) | ||
|
|
||
| func (s *ChatServerV2) GetCitationKeys( | ||
| ctx context.Context, | ||
| req *chatv2.GetCitationKeysRequest, | ||
| ) (*chatv2.GetCitationKeysResponse, error) { | ||
| actor, err := contextutil.GetActor(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| settings, err := s.userService.GetUserSettings(ctx, actor.ID) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| llmProvider := &models.LLMProviderConfig{ | ||
| APIKey: settings.OpenAIAPIKey, | ||
| } | ||
|
|
||
| citationKeys, err := s.aiClientV2.GetCitationKeys( | ||
| ctx, | ||
| req.GetSentence(), | ||
| actor.ID, | ||
| req.GetProjectId(), | ||
|
Comment on lines
+29
to
+33
|
||
| llmProvider, | ||
| ) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &chatv2.GetCitationKeysResponse{ | ||
| CitationKeys: citationKeys, | ||
| }, nil | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,142 @@ | ||||
| package client | ||||
|
|
||||
| // TODO: This file should not place in the client package. | ||||
|
||||
| // TODO: This file should not place in the client package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Junyi-99 I'm planning to eventually move this file to wherever internal/services/toolkit/client/get_conversation_title_v2.go will be moved to, since both files contain high-order business logic that doesn't belong to the client folder. Shall I leave this file here for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got copilot to review the PR. I didnt really look through its suggestions. Could you resolve copilot's comments and integrate any valid / viable suggestions? I think jun yi is busy these few days, i'll review later on this week if its still pending review! Thanks for your hardwork jiayi!
@Junyi-99 actually do we have a recommended PR to main workflow? Should we review only review PRs to main and allow freely merging to staging / dev branch for testing in a simulated prod env? Or should there be a preliminary review before merging to staging too?
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New citation-key functionality is added here but there are existing tests for other toolkit client behaviors (e.g. conversation title). Please add unit tests for GetBibliographyForCitation/GetCitationKeys (at minimum: field-exclusion behavior and prompt formatting / empty-citation handling) to prevent regressions.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetCitationKeysRequest includes an optional model_slug, but this handler doesn’t read
req.GetModelSlug()(and the downstream call currently hardcodes a model). Either plumb the requested model through to the client call, or remove the field from the proto to avoid a misleading API surface.