Open
Conversation
…ure/kernelmodule # Conflicts: # kernel/src/lib.rs
…e/kernelmodules # Conflicts: # build.rs # kernel/src/lib.rs # macros/Cargo.toml # src/modules.rs # src/modules/kernelmods.rs # src/modules/kernelmods/sample_module.rs
LCOV of commit
|
There was a problem hiding this comment.
Pull request overview
This PR introduces an in-tree kernel module system backed by build-time code generation, aiming to auto-discover kernel modules and generate a matching userspace-callable API for module calls.
Changes:
- Adds build-script discovery of
#[kernelmod_init],#[kernelmod_exit], and#[kernelmod_call]functions and generates kernel dispatch + userspace wrappers. - Introduces a
PosixErrorerrno enum and integrates it into the module-call return path. - Extends proc-macros with a
#[kernelmod_call]wrapper generator and updates syscall inline-asm stubs to returnisize.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
build.rs |
Adds kernel-module discovery and generates modules_kernel.rs/modules_uspace.rs. |
macros/src/lib.rs |
Adds #[kernelmod_call] proc-macro and wrapper generation logic. |
src/modules.rs |
Adds module system entrypoints and includes generated kernel module glue. |
src/uspace.rs |
Includes generated userspace module wrapper code. |
src/error.rs |
Adds PosixError errno definitions and conversions. |
src/lib.rs |
Exposes new modules and error modules from the crate root. |
machine/arm/src/asm.rs |
Updates syscall macro implementation to return a value via inline asm. |
machine/testing/src/asm.rs |
Updates syscall macro stubs to return isize for non-zero-arg forms. |
src/modules/sample_module.rs |
Adds a commented-out sample kernel module illustrating expected patterns. |
.gitignore |
Adds ignores for module-related generated files (paths currently appear mismatched). |
src/utils.rs |
Whitespace-only change. |
src/uspace/.gitkeep |
Adds placeholder to keep src/uspace/ directory in git. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.