Skip to content

Add Azure Email health check#18917

Open
hishamco wants to merge 8 commits intomainfrom
hishamco/azure-email-health-check
Open

Add Azure Email health check#18917
hishamco wants to merge 8 commits intomainfrom
hishamco/azure-email-health-check

Conversation

@hishamco
Copy link
Copy Markdown
Member

No description provided.

@hishamco hishamco mentioned this pull request Feb 28, 2026
11 tasks
@hishamco
Copy link
Copy Markdown
Member Author

Due to the limitation of ACE in the region, @BenedekFarkas, could you please test the health check or send me test credentials privately if you don't mind

I remembered that I suffered from the configuration at the time of implementing the Azure Email

@BenedekFarkas BenedekFarkas self-requested a review March 2, 2026 11:03
Copy link
Copy Markdown
Member

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once comments are resolved

Copy link
Copy Markdown
Member

@BenedekFarkas BenedekFarkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigating to /health/live throws error for me:

InvalidOperationException: Unable to resolve service for type 'OrchardCore.Email.Azure.Models.AzureEmailOptions' while attempting to activate 'OrchardCore.Email.Azure.HealthChecks.AzureEmailHealthCheck'.

@hishamco hishamco requested a review from BenedekFarkas March 7, 2026 03:07
hishamco and others added 2 commits March 7, 2026 06:08
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
@sebastienros
Copy link
Copy Markdown
Member

Still waiting for changes

@hishamco
Copy link
Copy Markdown
Member Author

hishamco commented Apr 2, 2026

Changes have been made. I might need to test it myself. I will try to get the test credentials

@hishamco
Copy link
Copy Markdown
Member Author

hishamco commented Apr 3, 2026

@BenedekFarkas seems the API call is not working. I just replaced it with a send call to an invalid email. Just confirm it's not charged.

FYI in noticed from Metrics that a failing email is not counted, but I need your confirmation to merge this PR

@hishamco hishamco requested a review from BenedekFarkas April 3, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants