Open
Conversation
mvdhoek1
approved these changes
Sep 23, 2024
Contributor
mvdhoek1
left a comment
mvdhoek1
left a comment
There was a problem hiding this comment.
Heb het niet zelf getest maar dit ziet er goed uit!
dtakken
force-pushed
the
fix-all-the-tests
branch
from
79294f5 to
31394d0
Compare
dtakken
force-pushed
the
fix-all-the-tests
branch
6 times, most recently
from
4d554b1 to
ccf5917
Compare
|
Coverage report for commit: bf8f82c Summary - Lines: 24.20% | Methods: 23.61%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dtakken
force-pushed
the
fix-all-the-tests
branch
from
ccf5917 to
bf8f82c
Compare
Contributor
Author
|
Ik heb de tests niet helemaal verwijderd maar wel versoberd. En coverage toegevoegd, omdat ik toch bezig was. ;) |
SimonvanWijhe
approved these changes
Oct 8, 2024
Contributor
SimonvanWijhe
left a comment
SimonvanWijhe
left a comment
There was a problem hiding this comment.
Goed werk!
Ik ben benieuwd of de tests ook gaan slagen op 8.1. Je zou deze alvast kunnen toevoegen aan de tests action: https://github.com/OpenWebconcept/plugin-openpub-base/pull/27/files#diff-7314d0ebbd2e9537ae4889316745b4fd2fa43cb86275c9caae18a86ba228b642R18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the unit tests, among other things