fix: implement upstream lookup logic for sites on php 7.4#4
Open
fix: implement upstream lookup logic for sites on php 7.4#4
Conversation
mvdhoek1
approved these changes
Mar 3, 2026
mvdhoek1
left a comment
mvdhoek1
left a comment
There was a problem hiding this comment.
Ondanks het mierenneuken en oude bestaande code vind ik de parseURLvariables() method wel een stuk beter beter te begrijpen/lezen.
| */ | ||
| private function parseURLvariables(): string | ||
| { | ||
| $arg_and = ['type:adres']; |
There was a problem hiding this comment.
Mierenneuken maar snake_case vs camelCase 🐜
| $arg_and = ['type:adres']; | ||
| $arg_or = []; | ||
|
|
||
| if (!empty($this->zip)) { |
There was a problem hiding this comment.
De class properties zijn niet typed helaas maar de postcode dient altijd een string te zijn.
Een empty() check kan duiden op een code smell. Niet relevant voor deze PR maar denk dat we deze plugin later nog eens moeten checken in zijn geheel. Ik schrijf hem even op voor later.
| define('GF_BAG_DIR', basename(__DIR__)); | ||
| define('GF_BAG_ROOT_PATH', __DIR__); | ||
| define('GF_BAG_VERSION', '1.1.3'); | ||
| define('GF_BAG_VERSION', '1.1.6'); |
There was a problem hiding this comment.
Ik zou de versie niet bijwerken in deze PR. Mocht iemand in de tussentijd een andere versie releasen dan ontstaat daar weer een conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alleen voor review, geen merge naar master. Hier wordt dan een legacy versie voor aangemaakt (v1.1.6)