Draft
Conversation
Contributor
Author
|
Hi @cthoyt! This is the PR I told you about :) |
cthoyt
reviewed
Apr 2, 2026
| return None | ||
|
|
||
|
|
||
| def _iri_to_curie(iri: str) -> str: |
There was a problem hiding this comment.
https://bioregistry.readthedocs.io/en/latest/api/bioregistry.parse_iri.html#parse-iri implements this with much more logic baked in and testing already done for you :)
cthoyt
reviewed
Apr 2, 2026
| return None | ||
|
|
||
|
|
||
| def _search_ols(name: str, ontologies: list[str], timeout: int = 10) -> str | None: |
There was a problem hiding this comment.
the harness for this is implemented in https://ols-client.readthedocs.io/en/latest/usage.html#ols_client.client.Client.search, I have been meaning to improve the docs on this for some time. maybe helpful for you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16.
Allows a user to enrich an existing machine-readable definition or create a new one with ontology ids out of the box.
This is still experimental. Feedback is welcome!