Merged
Conversation
Signed-off-by: romanetar <roman_ag@hotmail.com>
smarcet
reviewed
Mar 6, 2026
| @@ -1185,7 +1185,7 @@ public function updateSponsorServicesStatistics(Summit $summit, int $sponsor_id, | |||
| $statistics = $summit_sponsor->getSponsorServicesStatistics(); | |||
| if (!$statistics) { | |||
| $statistics = new SponsorStatistics(); | |||
Collaborator
There was a problem hiding this comment.
@romanetar please use SponsorServicesStatisticsFactory::build
dont do here
$statistics = new SponsorStatistics();
smarcet
reviewed
Mar 6, 2026
| if (!$statistics) { | ||
| $statistics = new SponsorStatistics(); | ||
| $statistics->setSponsor($summit_sponsor); | ||
| $summit_sponsor->setSponsorServicesStatistics($statistics); |
Collaborator
There was a problem hiding this comment.
@romanetar also please add an unit test for this case and lets be sure that are running at CI (.github/workflows/push.yml)
add proper entry on dep matrix here
summit-api/.github/workflows/push.yml
Line 71 in 0c6a820
smarcet
requested changes
Mar 6, 2026
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@romanetar please review comments
Signed-off-by: romanetar <roman_ag@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.