Skip to content

Add new button to create a new folder when saving screenshots#211

Merged
alexanderbock merged 9 commits intomasterfrom
issue/3680-reset_screenshot_date
Apr 9, 2026
Merged

Add new button to create a new folder when saving screenshots#211
alexanderbock merged 9 commits intomasterfrom
issue/3680-reset_screenshot_date

Conversation

@alexanderbock
Copy link
Copy Markdown
Member

@alexanderbock alexanderbock commented Apr 7, 2026

…pelling issue with onShouldUpdateFramesChange->onShouldOutputFramesChange
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “use new folder” option when outputting frames during session playback, intended to force creation of a fresh screenshots output folder per playback run.

Changes:

  • Add a new checkbox in the Play Session panel to request a new output folder when outputting frames.
  • Pass the new option to the playback start button and toggle a RenderEngine screenshot property to trigger folder creation.
  • Add English locale strings for the new checkbox.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/panels/SessionRecordingPanel/PlaySession.tsx Adds UI state + checkbox to control “use new folder” behavior and passes it to the play button.
src/panels/SessionRecordingPanel/Playback/PlaybackPlayButton.tsx Uses the new flag to toggle a screenshot-related property before starting playback with frame output.
public/locales/en/panel-sessionrecording.json Adds label/tooltip strings for the new checkbox.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@ylvaselling ylvaselling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not close #3777 because the folder is called the date of today, which means the screenshots go in the same folder? I tried toggling the checkbox as well but multiple session recordings end up in the same folder, with the name of today's date

@alexanderbock
Copy link
Copy Markdown
Member Author

This does not close #3777 because the folder is called the date of today, which means the screenshots go in the same folder? I tried toggling the checkbox as well but multiple session recordings end up in the same folder, with the name of today's date

Mhh.. not sure I understand? The dates should have the hours and minutes in the folder as well? I think we might want to add seconds to it?
image

@WeirdRubberDuck WeirdRubberDuck self-requested a review April 8, 2026 15:36
Copy link
Copy Markdown
Collaborator

@WeirdRubberDuck WeirdRubberDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm experiencing the same issue that Ylva is explaining - there is a new folder created for the current date, with the timestamp when I created it. However, when I make a new recording, no new folder is created. NVM pulling the last changes seems to have fixed it. Thought I had it all, sorry

Another wis h is that now that we have another button related to the outputting of frames, that we group these setting together a bit more. How baout something like this?

Image

And if you wish, here's how the code for that looks like.

        <BoolInput
          label={t('output-frames.label')}
          value={shouldOutputFrames}
          onChange={onShouldOutputFramesChange}
          disabled={!isIdle}
          info={t('output-frames.tooltip')}
        />
        <Stack ml={'xs'} mb={'xs'}>
          <NumericInput
            value={outputFramerate}
            placeholder={t('framerate.placeholder')}
            aria-label={t('framerate.aria-label')}
            label={'Framerate'} // TODO should be translated
            onEnter={(value) => setOutputFramerate(value)}
            disabled={!shouldOutputFrames || !isIdle}
          />
          <BoolInput
            label={t('output-new-folder.label')}
            value={shouldOutputUseNewFolder}
            onChange={setShouldOutputUseNewFolder}
            info={t('output-new-folder.tooltip')}
            disabled={!shouldOutputFrames || !isIdle}
          />
        </Stack> 

Copy link
Copy Markdown
Collaborator

@WeirdRubberDuck WeirdRubberDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good now

Maybe a bit confusing that when unchecking the checkbox, it keeps using the latest folder (with seconds in the name), which was set to be a "new" folder just before. But it's also just the way it works I guess

@alexanderbock alexanderbock merged commit ce64bdb into master Apr 9, 2026
1 check passed
@alexanderbock alexanderbock deleted the issue/3680-reset_screenshot_date branch April 9, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frames from multiple session recording end up the same folder More user-friendly name to reset the screenshot date folder

4 participants