Add new button to create a new folder when saving screenshots#211
Add new button to create a new folder when saving screenshots#211alexanderbock merged 9 commits intomasterfrom
Conversation
…pelling issue with onShouldUpdateFramesChange->onShouldOutputFramesChange
There was a problem hiding this comment.
Pull request overview
Adds a new “use new folder” option when outputting frames during session playback, intended to force creation of a fresh screenshots output folder per playback run.
Changes:
- Add a new checkbox in the Play Session panel to request a new output folder when outputting frames.
- Pass the new option to the playback start button and toggle a RenderEngine screenshot property to trigger folder creation.
- Add English locale strings for the new checkbox.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/panels/SessionRecordingPanel/PlaySession.tsx |
Adds UI state + checkbox to control “use new folder” behavior and passes it to the play button. |
src/panels/SessionRecordingPanel/Playback/PlaybackPlayButton.tsx |
Uses the new flag to toggle a screenshot-related property before starting playback with frame output. |
public/locales/en/panel-sessionrecording.json |
Adds label/tooltip strings for the new checkbox. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/panels/SessionRecordingPanel/Playback/PlaybackPlayButton.tsx
Outdated
Show resolved
Hide resolved
ylvaselling
left a comment
There was a problem hiding this comment.
This does not close #3777 because the folder is called the date of today, which means the screenshots go in the same folder? I tried toggling the checkbox as well but multiple session recordings end up in the same folder, with the name of today's date
src/panels/SessionRecordingPanel/Playback/PlaybackPlayButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
There was a problem hiding this comment.
I'm experiencing the same issue that Ylva is explaining - there is a new folder created for the current date, with the timestamp when I created it. However, when I make a new recording, no new folder is created. NVM pulling the last changes seems to have fixed it. Thought I had it all, sorry
Another wis h is that now that we have another button related to the outputting of frames, that we group these setting together a bit more. How baout something like this?
And if you wish, here's how the code for that looks like.
<BoolInput
label={t('output-frames.label')}
value={shouldOutputFrames}
onChange={onShouldOutputFramesChange}
disabled={!isIdle}
info={t('output-frames.tooltip')}
/>
<Stack ml={'xs'} mb={'xs'}>
<NumericInput
value={outputFramerate}
placeholder={t('framerate.placeholder')}
aria-label={t('framerate.aria-label')}
label={'Framerate'} // TODO should be translated
onEnter={(value) => setOutputFramerate(value)}
disabled={!shouldOutputFrames || !isIdle}
/>
<BoolInput
label={t('output-new-folder.label')}
value={shouldOutputUseNewFolder}
onChange={setShouldOutputUseNewFolder}
info={t('output-new-folder.tooltip')}
disabled={!shouldOutputFrames || !isIdle}
/>
</Stack> 
Closes OpenSpace/OpenSpace#3777
Closes OpenSpace/OpenSpace#3680