Skip to content

Remove fade value and use animation for checkbox#208

Merged
ylvaselling merged 4 commits intomasterfrom
feature/fade-icon
Apr 9, 2026
Merged

Remove fade value and use animation for checkbox#208
ylvaselling merged 4 commits intomasterfrom
feature/fade-icon

Conversation

@ylvaselling
Copy link
Copy Markdown
Collaborator

Switches the fading checkbox from this:

2026-03-30.11-07-52.mp4

To this:

2026-03-30.11-07-34.mp4

This has the benefit of:

  • Feels more responsive
  • More performant as it doesn't need the fade value

@WeirdRubberDuck WeirdRubberDuck self-requested a review March 30, 2026 11:20
Copy link
Copy Markdown
Collaborator

@WeirdRubberDuck WeirdRubberDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The animation shows an ugly "jack" when the icon size is increased, however. It would be great if we could fix this now rather than later, to make the component more usable.

It might be solvable by just increasing the background size to make sure the edge is never visible

Here's how it looks for an md sized icon:

incon.mp4

Otherwise, it looks great

@ylvaselling
Copy link
Copy Markdown
Collaborator Author

Nice! The animation shows an ugly "jack" when the icon size is increased, however. It would be great if we could fix this now rather than later, to make the component more usable.

It might be solvable by just increasing the background size to make sure the edge is never visible

Here's how it looks for an md sized icon:
incon.mp4

Otherwise, it looks great

👍 Fixed it, want to take a look before I merge?

@ylvaselling ylvaselling merged commit 9da4b3f into master Apr 9, 2026
1 check passed
@ylvaselling ylvaselling deleted the feature/fade-icon branch April 9, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants